Ensured that tuples are always cast to numpy arrays when indexing.

SciTools / biggus

:no_entry: [DEPRECATED] Virtual large arrays and lazy evaluation.

http://biggus.readthedocs.io/

GNU Lesser General Public License v3.0

54 stars 27 forks source link

Ensured that tuples are always cast to numpy arrays when indexing. #160

Closed pelson closed 7 years ago

marqh commented 8 years ago

This change looks pretty good to me

is there any reason why it's not good to merge?

pelson commented 8 years ago

is there any reason why it's not good to merge?

Just looking through this again, I'm worried I've inadvertently introduced the ability to do mask indexing, without actually implementing it correctly. Is there anything driving the question @marqh, or is it just a case of trying to round up the stragglers?

pelson commented 7 years ago

Closing this one out as wontfix.