search

SciTools / biggus

:no_entry: [DEPRECATED] Virtual large arrays and lazy evaluation.
http://biggus.readthedocs.io/
GNU Lesser General Public License v3.0
54 stars 27 forks source link

TST: Skip double-ellipsis test with NumPy >= 1.12.0. #202

Closed QuLogic closed 7 years ago

QuLogic commented 7 years ago

It is no longer supported.

Eventually, should make a decision on whether biggus should support this too.

pp-mo commented 7 years ago

I see that numpy now disallows any indexing with multiple ellipses. If this is "the future", would it not make more sense to remove this altogether ? I guess I mean, "it should be an error in biggus also, and we should change this test to exercise that".

I found this rather old discussion : https://mail.scipy.org/pipermail/numpy-discussion/2006-February/006617.html So, it was originally retained for compatibility with "numeric". Clearly, despite the above comments, they did not deprecate it in v1.0.

Do you know of other good reasons for retaining it?

QuLogic commented 7 years ago

I was not sure if there would be any adverse repercussions for either biggus or iris, so I opted for simply disabling the test. I don't really know if there are any good reasons for keeping the behaviour.