search

SciTools / cartopy

Cartopy - a cartographic python library with matplotlib support
https://scitools.org.uk/cartopy/docs/latest
BSD 3-Clause "New" or "Revised" License
1.42k stars 363 forks source link

First SRTM tile north of equator not found for 0° S, needs to be 0° N #514

Closed odermatt closed 9 years ago

odermatt commented 9 years ago

SRTM3_retrieve for lat=0 leads to y=S00 and srtm_downloader.url(params)=None, leaving some empty tiles north of Lake Victoria. _lake-victoria_2003-01-01_2011-12-31_owt_dominant_class_cc_majority_class

After replacing > by >= in row 171 of srtm.py, I get y=N00, a successful response by the srtm_downloader and a complete basemap. lake-victoria_2003-01-01_2011-12-31_owt_dominant_class_cc_majority_class

pelson commented 9 years ago

Thanks @odermatt. Did you want to submit a PR, or are you happy for us to take it from here?

odermatt commented 9 years ago

I'm afraid I don't have the permissions to submit a PR: remote: Permission to SciTools/cartopy.git denied to odermatt.

esc24 commented 9 years ago

You'll need to fork scitools/cartopy to create a cartopy repository in your github space i.e. odermatt/cartopy. You can then push your branch to that repository and create a PR from odermatt/cartopy to scitools/cartopy. I hope that makes sense. The process is described for Iris at http://scitools.org.uk/iris/docs/latest/developers_guide/gitwash/git_development.html and the same applies for cartopy.

odermatt commented 9 years ago

Thanks for the instructions, but in that case I'd prefer if @pelson could take it from here.

pelson commented 9 years ago

Thanks for the instructions, but in that case I'd prefer if @pelson could take it from here.

No problems. I'd be more than happy to do it. If you ever want to get involved with the development of an open source package generally I find conference sprints (e.g the Scipy or PyData conferences) a great way to get going.

pelson commented 9 years ago

515 closes.