adopt ruff - Githubissues

SciTools / cf-units

Units of measure as required by the Climate and Forecast (CF) Metadata Conventions

https://cf-units.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

66 stars 49 forks source link

adopt ruff #353

Closed bjlittle closed 1 year ago

bjlittle commented 1 year ago

🚀 Pull Request

Description

This PR adopts ruff and drops the explicit use of isort and flake8.

Running ruff across the codebase rediscovers a whole collections of exceptions that clearly have been missed for flake8 et al compliance.

[ ] Once #352 is merged, then I'll rebase and add the ruff badge.

rcomer commented 1 year ago

Lots of style changes here. Is it worth adding a .git-blame-ignore-revs?

trexfeathers commented 1 year ago

I really didn't want to get involved here but based on @rcomer's comments I think we need a team discussion. I think we can all agree that we don't want inconsistency between our repos, so adopting ruff for cf-units would therefore create an implicit goal to use it for all our repos, and that's a big decision.