search

SciTools / cf-units

Units of measure as required by the Climate and Forecast (CF) Metadata Conventions
https://cf-units.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
64 stars 47 forks source link

Update antlr version to 4.11.1 #368

Closed rcomer closed 1 year ago

rcomer commented 1 year ago

🚀 Pull Request

Description

Helps with #313. Not sure if it closes it, as it might still be good to make the dependency optional.

I figured out what to do with a combination of the README and this helpful comment and the PR it links to. The only changes I made manually were the version number in three files. All the other changes are from running the compile.py script. I have not attempted to understand them!

The newest version of this dependency available from conda-forge is 4.13.0, but it was noted at https://github.com/SciTools/cf-units/issues/313#issuecomment-1601899713 that lots of other packages use 4.11.1, so it is likely helpful to be consistent.

Tests pass for me locally. ~I do not expect them to pass in CI because I have not updated the lockfiles. Can anyone tell me how to do that locally?~

rcomer commented 1 year ago

~Huh. Tests do pass. I guess antlr4-python3-runtime is getting installed independently of the lockfiles?~

rcomer commented 1 year ago

Added some notes for next time.

rcomer commented 1 year ago

~Codacy seems to be stuck 😕~

rcomer commented 1 year ago

I got a full set of green ticks! 🥳

rcomer commented 1 year ago

Thanks @trexfeathers 🥳