Closed trexfeathers closed 2 years ago
Merging #128 (e6b2bc0) into unstructured_scheme (7d09381) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## unstructured_scheme #128 +/- ##
====================================================
Coverage 99.48% 99.48%
====================================================
Files 24 24
Lines 1550 1550
====================================================
Hits 1542 1542
Misses 8 8
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7d09381...e6b2bc0. Read the comment docs.
@stephenworsley I'd appreciate your thoughts on why the changed dependencies have caused regressions. I've tried re-running the benchmarking job but they're still there.
For time_make_grid
, my guess would be something to do with cartopy running these lines:
https://github.com/SciTools-incubator/iris-esmf-regrid/blob/82c494875894b7e54fd8c6c2f6707b917d26eac2/esmf_regrid/_esmf_sdo.py#L157-L158
Cartopy has gone up a version here, as has Proj. I'm not sure about the other slowdowns.
I'm not sure about the other slowdowns.
I don't suppose they might also depend on the same stuff as time_make_grid
? Which, as you say, we already understand (and have merged on main
).
Includes coverage packages in project dependencies and updates the lockfiles.