search

SciTools / iris-esmf-regrid

A collection of structured and unstructured ESMF regridding schemes for Iris.
https://iris-esmf-regrid.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
19 stars 17 forks source link

Use more stable version of connectivity indices #144

Closed stephenworsley closed 2 years ago

stephenworsley commented 2 years ago

Using indices_by_location() ensures that regridding still works in the case where face_node_connectivity.location_axis = 1.

trexfeathers commented 2 years ago

Also need a change here:

https://github.com/stephenworsley/iris-esmf-regrid/blob/9af2e801eb1af1ec598790e102ce5fef3a49a6a8/esmf_regrid/experimental/unstructured_scheme.py#L583

codecov[bot] commented 2 years ago

Codecov Report

Merging #144 (3ad2948) into unstructured_scheme (53e8b61) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           unstructured_scheme     #144   +/-   ##
====================================================
  Coverage                99.54%   99.54%           
====================================================
  Files                       27       27           
  Lines                     1767     1767           
====================================================
  Hits                      1759     1759           
  Misses                       8        8
Impacted Files Coverage Δ
esmf_regrid/experimental/unstructured_scheme.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53e8b61...3ad2948. Read the comment docs.