search

SciTools / iris-esmf-regrid

A collection of structured and unstructured ESMF regridding schemes for Iris.
https://iris-esmf-regrid.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
19 stars 17 forks source link

Increase standard benchmark regression tolerance #162

Closed trexfeathers closed 2 years ago

trexfeathers commented 2 years ago

Benchmarks are currently over-sensitive and regularly flag false positive regressions.

codecov[bot] commented 2 years ago

Codecov Report

Merging #162 (bc36fed) into main (039ce21) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          27       27           
  Lines        2073     2073           
=======================================
  Hits         2064     2064           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 039ce21...bc36fed. Read the comment docs.

stephenworsley commented 2 years ago

I suspect that we might also want to reduce the number of test cases we use as well for the sake of time, though given the kind of variability we're seeing this is probably also necessary.