SciTools / iris-esmf-regrid

A collection of structured and unstructured ESMF regridding schemes for Iris.
https://iris-esmf-regrid.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
20 stars 17 forks source link

Make weights array handling more robust #166

Closed stephenworsley closed 2 years ago

stephenworsley commented 2 years ago

With scipy.sparse now offering arrays as well as matrices, the code ought to be improved so that it can work with either matrices or arrays representing the weights, especially since precomputed weights could potentially be given in either form. This also clarifies in the code where matrix multiplication is happening rather than array multiplication.

codecov[bot] commented 2 years ago

Codecov Report

Merging #166 (5a56f39) into main (f97a0bf) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          27       27           
  Lines        2469     2469           
=======================================
  Hits         2457     2457           
  Misses         12       12           
Impacted Files Coverage Δ
esmf_regrid/esmf_regridder.py 95.08% <100.00%> (ø)
esmf_regrid/experimental/io.py 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more