Refactor and unify regridding schemes

stephenworsley commented 2 years ago

Refactor all regridder classes to inherit from a single class.

codecov[bot] commented 2 years ago

Codecov Report

Merging #198 (0a6cd3c) into main (3440343) will decrease coverage by 0.50%. The diff coverage is 97.46%.

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   99.22%   98.73%   -0.50%     
==========================================
  Files          28       30       +2     
  Lines        3102     3323     +221     
==========================================
+ Hits         3078     3281     +203     
- Misses         24       42      +18

Impacted Files	Coverage Δ
esmf_regrid/experimental/io.py	`99.26% <83.33%> (-0.74%)`	:arrow_down:
esmf_regrid/experimental/unstructured_scheme.py	`93.93% <89.47%> (-4.63%)`	:arrow_down:
esmf_regrid/schemes.py	`96.09% <95.02%> (-1.36%)`	:arrow_down:
.../tests/unit/experimental/io/test_round_tripping.py	`100.00% <100.00%> (ø)`
...nstructured_scheme/test_GridToMeshESMFRegridder.py	`100.00% <100.00%> (ø)`
...nstructured_scheme/test_MeshToGridESMFRegridder.py	`97.05% <100.00%> (-2.95%)`	:arrow_down:
..._scheme/test_regrid_rectilinear_to_unstructured.py	`100.00% <100.00%> (ø)`
..._scheme/test_regrid_unstructured_to_rectilinear.py	`100.00% <100.00%> (ø)`
...regrid/tests/unit/schemes/test_ESMFAreaWeighted.py	`100.00% <100.00%> (ø)`
...smf_regrid/tests/unit/schemes/test_ESMFBilinear.py	`100.00% <100.00%> (ø)`
... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

trexfeathers commented 1 year ago

More of this goodness please 🙏

https://github.com/SciTools-incubator/iris-esmf-regrid/pull/219#issuecomment-1464023514

trexfeathers commented 1 year ago

Let's do it 🚀

SciTools / iris-esmf-regrid

Refactor and unify regridding schemes #198

Codecov Report