SciTools / iris-esmf-regrid

A collection of structured and unstructured ESMF regridding schemes for Iris.
https://iris-esmf-regrid.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
19 stars 17 forks source link

Remove flake8 and black Nox sessions. #236

Closed trexfeathers closed 1 year ago

trexfeathers commented 1 year ago

In line with Iris, this PR proposes relying purely on pre-commit.ci (already enabled on this repo) for linting tasks, doing away with independently managed Nox sessions.

This reduces duplication, and removes the risk of divergence between the Nox sessions and the pre-commit setup (which recently caused this CI failure - different linter versions were insisting on different standards).

Iris' decision-making history:

codecov[bot] commented 1 year ago

Codecov Report

Merging #236 (01bfcdb) into main (dbd1cb7) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          28       28           
  Lines        2829     2829           
=======================================
  Hits         2811     2811           
  Misses         18       18           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

trexfeathers commented 1 year ago

I believe black and flake should now not be needed in the requirements files. They are absent from the Iris requirements (removed with this PR SciTools/iris#4181).

Good catch, thanks

trexfeathers commented 1 year ago

Looks like the pre-commit config is missing the appropriate subcommands to mimic what was happening in the Nox session. Will look later.