SciTools / iris-esmf-regrid

A collection of structured and unstructured ESMF regridding schemes for Iris.
https://iris-esmf-regrid.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
19 stars 17 forks source link

Add env vars to sphinx config #258

Closed zklaus closed 1 year ago

zklaus commented 1 year ago

Readthedocs doesn't activate Conda environments and also doesn't use conda run. As a consequence, crucial environment variables are not set, preventing the successful building of the documentation.

This PR adds the environment variables in Sphinx' conf.py, providing a workaround for that problem. This might need to be updated in the future if either different variables are needed (e.g. Proj recently moved from PROJ_LIB to PROJ_DATA), or if Readthedocs addresses this, e.g. in readthedocs/readthedocs.org#5339.

Fixes #251

codecov[bot] commented 1 year ago

Codecov Report

Merging #258 (1d2985d) into main (8076f40) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          28       28           
  Lines        3102     3102           
=======================================
  Hits         3078     3078           
  Misses         24       24           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bjlittle commented 1 year ago

Hey @zklaus, thanks for pushing this along 💯 🍻

I just approved your request for access to RTD as a maintainer for iris-esmf-regrd, so you're unblocked now 👍