SciTools / iris-esmf-regrid

A collection of structured and unstructured ESMF regridding schemes for Iris.
https://iris-esmf-regrid.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
19 stars 17 forks source link

Less repetition in `schemes` testing #269

Closed trexfeathers closed 1 year ago

trexfeathers commented 1 year ago

A follow on from #266, implementing improved test abstraction.

We have made a good start at reducing duplication in iris-esmf-regrid, but the remaining duplication still makes reviews very difficult. So I felt it important to demonstrate how improvements could be made where similar testing is desired against different elements of the code.

trexfeathers commented 1 year ago

Line count in esmf_regrid/tests/unit/schemes:

codecov[bot] commented 1 year ago

Codecov Report

Merging #269 (f4d6c20) into main (bad51a3) will decrease coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   98.79%   98.67%   -0.13%     
==========================================
  Files          33       34       +1     
  Lines        3563     3236     -327     
==========================================
- Hits         3520     3193     -327     
  Misses         43       43              
Impacted Files Coverage Δ
...smf_regrid/tests/unit/schemes/_common_regridder.py 100.00% <100.00%> (ø)
esmf_regrid/tests/unit/schemes/_common_scheme.py 100.00% <100.00%> (ø)
...regrid/tests/unit/schemes/test_ESMFAreaWeighted.py 100.00% <100.00%> (ø)
...sts/unit/schemes/test_ESMFAreaWeightedRegridder.py 100.00% <100.00%> (ø)
...smf_regrid/tests/unit/schemes/test_ESMFBilinear.py 100.00% <100.00%> (ø)
...d/tests/unit/schemes/test_ESMFBilinearRegridder.py 100.00% <100.00%> (ø)
esmf_regrid/tests/unit/schemes/test_ESMFNearest.py 100.00% <100.00%> (ø)
...id/tests/unit/schemes/test_ESMFNearestRegridder.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions[bot] commented 1 year ago

@SciTools-incubator/esmf-regrid-devs This pull-request is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this pull-request will close automatically in 7 days time.

trexfeathers commented 1 year ago

Closing due to lack of interest