search

SciTools / iris-esmf-regrid

A collection of structured and unstructured ESMF regridding schemes for Iris.
https://iris-esmf-regrid.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
19 stars 17 forks source link

Allow boundless coordinates for bilinear and nearest regridders #276

Closed stephenworsley closed 2 months ago

stephenworsley commented 1 year ago

The bilinear and nearest methods do not require coordinate bounds in order for ESMF to do regridding. This PR makes it so that grids without bound information are regridable via these methods.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@893fa9b). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #276 +/- ## ======================================= Coverage ? 98.39% ======================================= Files ? 37 Lines ? 4293 Branches ? 0 ======================================= Hits ? 4224 Misses ? 69 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 year ago

@SciTools-incubator/esmf-regrid-devs This pull-request is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this pull-request will close automatically in 7 days time.

ESadek-MO commented 1 year ago

@pp-mo

CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

bouweandela commented 3 months ago

It would be great if this could get reviewed and merged for reasons explained in https://github.com/SciTools-incubator/iris-esmf-regrid/issues/368#issuecomment-2178488893. Would it help to speed this up if I did a review?

pp-mo commented 2 months ago

@stephenworsley please update + I will progress !