search

SciTools / iris-grib

GRIB interface for Iris.
https://iris-grib.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
22 stars 43 forks source link

Incomplete validity checking in GDT 3.10 #188

Open pp-mo opened 4 years ago

pp-mo commented 4 years ago

The translation routine for gdt 3.10 (mercator grids) does not check all termplate parameters. Specifically, it doesn't check the scanningMode, nor any of the following parameters at the end of the template : "Orientation of the grid", "longitudinal direction grid length", "latitudinal direction grid length" (I haven't checked what the actual key names of those in ecCodes would be)

For comparison, the translation routine for gdt 3.12 (transverse mercator grids) does check the scanningMode parameter, and errors if contains unsupported settings.

pp-mo commented 4 years ago

NOTE I might be wrong about this. I think at least some of it is handled by the call to _calculate_proj_coords_from_grid_lengths. I still think that 'orientationOfTheGrid' is going unchecked though.