search

SciTools / iris-grib

GRIB interface for Iris.
https://iris-grib.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
22 stars 43 forks source link

iris-grib prettier #391

Open HGWright opened 3 months ago

HGWright commented 3 months ago

https://learn.scientific-python.org/development/guides/repo-review/?repo=scitools%2Firis-grib

bjlittle commented 3 months ago

@HGWright prettier uses node to do it's formatting, but unfortunately the glibc version on the VDI is too old i.e.,

> ldd --version
ldd (GNU libc) 2.17
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

And prettier seems to need 2.25+

So you might want to skip repo-review compliance with this i.e., instead add the following to the pyproject.toml,

[tool.repo-review]
ignore = [
    # https://learn.scientific-python.org/development/guides/style/#PC180
    "PC180",  # Uses prettier.
]