search

SciTools / iris-grib

GRIB interface for Iris.
https://iris-grib.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
22 stars 43 forks source link

Eccodes 2v36 #504

Closed pp-mo closed 2 months ago

pp-mo commented 2 months ago

Fixes for a couple of backwards-incompatibilities introduced in eccodes version 2.36

~N.B. this also tested OK against 2.35, for which these lines are required.~ ~However, it's not clear how old an eccodes this will support, since indicatorOfUnitOfTimeRange is only aliassed on loading -- not in saving, where setting it always+only uses indicatorOfUnitForForecastTime (the new form).~

From their release page, v2.33 is when indicatorOfUnitForForecastTime was introduced, which we now write on saves. Tested against eccodes v2.33 and v2.32 : confirmed the new code works with 2.33 but not 2.32. As stated in whatsnew + updated requirements yml files.

N.B. the old name indicatorOfUnitOfTimeRange is still used in grib1 loading, because that still requires it (!yuck!)

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.16%. Comparing base (6b97a7e) to head (69a8e90).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #504 +/- ## ========================================== + Coverage 89.13% 89.16% +0.02% ========================================== Files 8 8 Lines 2467 2473 +6 Branches 418 420 +2 ========================================== + Hits 2199 2205 +6 Misses 170 170 Partials 98 98 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pp-mo commented 2 months ago

NOTE: merging this should unblock subsequent PRs.