SciTools / iris-grib

GRIB interface for Iris.
https://iris-grib.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
22 stars 43 forks source link

Fix GRIB1 support #56

Open pp-mo opened 7 years ago

pp-mo commented 7 years ago

The GRIB1 load translation code (here) is still using GribWrappers, which is the only thing preventing us throwing all the old loader code away, including the GribWrapper class.

Technical Debt summary :


[ In fact this is still the bulk of code in iris_grib.__init__.py, though no longer publicly exported.

There is still a slippery kludge that means when you load a GRIB1 message the 'field' argument in a callback becomes a GribWrapper instead of a GribMessage (here).

So, this is now the only thing that GribWrapper is still used for, and the only remaining occasion that a user might possibly be concerned about what a GribWrapper looks like.

We haven't addressed this yet because GRIB1 usage is very low.

We should rewrite the Grib1 loader to use the modern message object + throw away all the old GribWrapper-based processing.

### Tasks
- [ ] https://github.com/SciTools/iris-grib/issues/488
- [ ] https://github.com/SciTools/iris-grib/issues/489
- [ ] https://github.com/SciTools/iris-grib/issues/490
pp-mo commented 2 months ago

Strategy ideas ...

Scoping

Strategy