Open pp-mo opened 1 day ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.60%. Comparing base (
9425d19
) to head (0255583
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
ruff-pre-commit
hook is now version 0.7.4, you've got it as 0.7.3
Just added in a re-ordering of the pre-commit hooks to match the current template order.
ruff-pre-commit
hook is now version 0.7.4, you've got it as 0.7.3Just added in a re-ordering of the pre-commit hooks to match the current template order.
You are still running on 0.7.3 for Ruff though.
You are still running on 0.7.3 for Ruff though.
Sorry, missed including that somehow!
I wonder if rather than setting strict=false
in your [tools.mypy]
section, it would be better to set strict=true
and capture all the failing error codes?
For iris-grib, this would require the following ignores in the pyproject.toml:
strict = true
disable_error_code = [
"arg-type",
"assignment",
"attr-defined",
"index",
"misc",
"name-defined",
"no-untyped-call",
"no-untyped-def",
"override",
"type-arg",
"union-attr",
"var-annotated",
]
These can then all be added to a new issue documenting the failing mypy tests for iris-grib?
What do you think?
Replaces #564
Don't understand why this was needed, since the branch location is the same. Seems like GitHub got confused somehow by my adding a commit + then removing it