search

SciTools / iris

A powerful, format-agnostic, and community-driven Python package for analysing and visualising Earth science data
https://scitools-iris.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
635 stars 283 forks source link

LBC File Integration Tests #3748

Closed trexfeathers closed 2 years ago

trexfeathers commented 4 years ago

After discussion with @nhsavage during #3743, we believe it would be beneficial to have one or two integration tests for parsing LBC files - to be stored in SciTools/iris-test-data.

@nhsavage will be sourcing these files in due course. It is important that these files:

See SciTools/iris-test-data, and try running any existing Iris integration tests that use iris-test-data files, for an idea of appropriate files.

nhsavage commented 4 years ago

actually I was wrong - there is already 1 integration test for LBCs. Data is at https://github.com/SciTools/iris-test-data/tree/master/test_data/FF/lbc and the test is here

nhsavage commented 4 years ago

Looking in detail at this file, many of the headers are wrong. It also will have been created with the legacy code makeBC not the more modern CreateBC (when this file was uploaded 18 Nov 2014, CreateBC had not been released (27 Feb 2015). Therefore an LBC file with some valid metadata should be included, possibly incliding a 360 day calendar and a variable resolution file.

github-actions[bot] commented 3 years ago

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

github-actions[bot] commented 2 years ago

This stale issue has been automatically closed due to a lack of community activity.

If you still care about this issue, then please either: