Derived coordinates are not loaded anymore?

valeriupredoi commented 3 years ago

📰 Custom Issue

Hey guys, one more for me today, I am using this file and loading it simple:

import iris

cs = iris.load("/home/valeriu/ESMValCore/tests/integration/cmor/_fixes/test_data/common_cl_ap.nc")
for c in cs:
    print(c)

with iris=3 I am not seeing the derived coordinates no more:

with iris=2.4:

b_bnds / (1)                        (atmosphere_hybrid_sigma_pressure_coordinate: 2; -- : 2)
 Dimension coordinates:
      atmosphere_hybrid_sigma_pressure_coordinate                           x       -
 Auxiliary coordinates:
      ap                                                                    x       -
      b                                                                     x       -
 Derived coordinates:
      air_pressure                                                          x       -
ap_bnds / (1)                       (atmosphere_hybrid_sigma_pressure_coordinate: 2; -- : 2)
 Dimension coordinates:
      atmosphere_hybrid_sigma_pressure_coordinate                           x       -
 Auxiliary coordinates:
      ap                                                                    x       -
      b                                                                     x       -
 Derived coordinates:
      air_pressure                                                          x       -
cloud_area_fraction_in_atmosphere_layer    (time: 1; atmosphere_hybrid_sigma_pressure_coordinate: 2; latitude: 3; longitude: 4)
 Dimension coordinates:
      time                                            x                                               -            -             -
      atmosphere_hybrid_sigma_pressure_coordinate     -                                               x            -             -
      latitude                                        -                                               -            x             -
      longitude                                       -                                               -            -             x
 Auxiliary coordinates:
      surface_air_pressure                            x                                               -            x             x
      ap                                              -                                               x            -             -
      b                                               -                                               x            -             -
 Derived coordinates:
      air_pressure                                    x                                               x            x             x
surface_air_pressure / (Pa)         (time: 1; latitude: 3; longitude: 4)
 Dimension coordinates:
      time                           x            -             -
      latitude                       -            x             -
      longitude                      -            -             x
 Attributes:
      additional_attribute: xyz

with iris=3.0:

b_bnds / (unknown)                  (atmosphere_hybrid_sigma_pressure_coordinate: 2; -- : 2)
 Dimension coordinates:
      atmosphere_hybrid_sigma_pressure_coordinate                           x       -
 Auxiliary coordinates:
      ap                                                                    x       -
      b                                                                     x       -
ap_bnds / (unknown)                 (atmosphere_hybrid_sigma_pressure_coordinate: 2; -- : 2)
 Dimension coordinates:
      atmosphere_hybrid_sigma_pressure_coordinate                           x       -
 Auxiliary coordinates:
      ap                                                                    x       -
      b                                                                     x       -
cloud_area_fraction_in_atmosphere_layer       (time: 1; atmosphere_hybrid_sigma_pressure_coordinate: 2; latitude: 3; longitude: 4)
 Dimension coordinates:
      time                                            x                                               -            -             -
      atmosphere_hybrid_sigma_pressure_coordinate     -                                               x            -             -
      latitude                                        -                                               -            x             -
      longitude                                       -                                               -            -             x
 Auxiliary coordinates:
      surface_air_pressure                            x                                               -            x             x
      ap                                              -                                               x            -             -
      b                                               -                                               x            -             -
surface_air_pressure / (Pa)         (time: 1; latitude: 3; longitude: 4)
 Dimension coordinates:
      time                           x            -             -
      latitude                       -            x             -
      longitude                      -            -             x
 Attributes:
      additional_attribute: xyz

where did the Derived coordinates go?

bjlittle commented 3 years ago

You guys happy with this?

bjlittle commented 3 years ago

@valeriupredoi thanks, nuke the repo dude :+1:

valeriupredoi commented 3 years ago

You guys happy with this?

looks good to me but @schlunma is the hybrid guru ->

bjlittle commented 3 years ago

I've checked all the other aux factories that iris implements, and cross referenced with the CF Metadata Conventions, Appendix D: Parametric Vertical Coordinates and there isn't another example of a parametric vertical coordinate with alternative formulas to derive the same quantity, apart from Atmosphere hybrid sigma pressure coordinate.

So I don't think there are other similar suprises lurking in the depths waiting to surprise us...

bjlittle commented 3 years ago

Unless you tell me otherwise, I'm cracking on with 3.0.1...

valeriupredoi commented 3 years ago

Make-It-So1

schlunma commented 3 years ago

Cheers @bjlittle, I'm happy with it :+1: Thanks for your quick help!!

trexfeathers commented 3 years ago

Closed by #3965

bjlittle commented 3 years ago

@bouweandela @valeriupredoi @schlunma @jvegasbsc

iris 3.0.1 has already been tagged, the docs have already been built on readthedocs, and I've just kicked of an update on the conda-forge iris-feedstock... almost there :wink:

I'll ping the ESMValTool WhatsApp thread when conda-forge has pushed the built iris 3.0.1 package to the Anaconda Cloud channel - then you can install and test. Good luck! :crossed_fingers:

valeriupredoi commented 3 years ago

legend @bjlittle cheers very much! :beer:

bouweandela commented 3 years ago

Thanks for the amazingly quick bugfix and release! :partying_face:

bjlittle commented 3 years ago

Hit conda search -c conda-forge iris until iris 3.0.1 pops up... not sure when the channel is populated

bjlittle commented 3 years ago

💥 3.0.1 is live on conda-forge! go for it!

bjlittle commented 3 years ago

Installed iris 3.0.1 and tested... seems to work for me :wink:

SciTools / iris

Derived coordinates are not loaded anymore? #3961

📰 Custom Issue