SciTools / iris

A powerful, format-agnostic, and community-driven Python package for analysing and visualising Earth science data
https://scitools-iris.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
625 stars 283 forks source link

Link Checking Procedure #4140

Open rcomer opened 3 years ago

rcomer commented 3 years ago

šŸ“° Custom Issue

Following the success of @jamespā€™s GitHub Action Workflow to update conda lock files, the CI tests on contributorsā€™ pull requests are protected from dependency updates and we can be fairly sure that any failures in the main tests are caused by the PRā€™s change. I think it would be great if, as far as possible, all CI failures in a PR were caused by that PRā€™s change.

Could we remove doc link checking from the PRs and have a regular GitHub Action to do it instead? It mostly fails because some external documentation has moved, so it doesnā€™t make sense to me that unrelated changes should be held up by it. I donā€™t really know anything about GitHub Actions, but this looks relevant: https://github.com/lycheeverse/lychee-action

jamesp commented 3 years ago

I'm all for this. I think PRs should be as atomic as possible

jamesp commented 3 years ago

We already have the configuration in cirrus ci, perhaps @bjlittle knows if it's possible to run cron-style jobs in cirrus? If not we could follow the template of the lockfile update github action

bjlittle commented 3 years ago

@jamesp Yup, you can run cron style jobs in cirrus-ci šŸ‘

See https://cirrus-ci.org/guide/writing-tasks/#cron-builds

github-actions[bot] commented 10 months ago

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

trexfeathers commented 10 months ago

I really want to make this work šŸ¤ž