SciTools / iris

A powerful, format-agnostic, and community-driven Python package for analysing and visualising Earth science data
https://scitools-iris.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
637 stars 284 forks source link

Errors in netcdf save code relating to string data. #4502

Open pp-mo opened 2 years ago

pp-mo commented 2 years ago

Just spotted this, found that some places in the netcdf code are testing for dtype.kind == 'u' which does not work, should be capital - 'U' Creating an Issue instead of PR for now, as not clear what the implications of this are, nor what might change if you fix it

🐛 Bug Report

This is a coding bug, not seen what actual behaviour might be -- that needs investigation.

Happens here and here, but is correct here.

github-actions[bot] commented 1 year ago

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

github-actions[bot] commented 1 year ago

This stale issue has been automatically closed due to a lack of community activity.

If you still care about this issue, then please either:

pp-mo commented 1 year ago

I think this is maybe still worth dealing with, especially if it links to problems I more recently stumbled over e.g. #5362 #4412

github-actions[bot] commented 4 days ago

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.