Science-for-Nature-and-People / BibScan

R package to batch download PDFs from a Web of Science search
5 stars 8 forks source link

Replaces .bib file in output directory #26

Open cristinasparks opened 5 years ago

cristinasparks commented 5 years ago

If the output directory is the same as the input directory, and the .bib file is in that directory, running the package will remove the .bib file

msleckman commented 5 years ago

MS review:

Test 1: Scanned 10 publications related to the topic "windpower":

Test 2: Scanned 10 publications related to the topic "drones conservation:

Test 3: Scanned 10 publications related to the topic of "Yellowstone National Park":

When the input bib file is stored in the "outdir" folder, all previous input files, including the bib file used to perform the download, are overwritten by the output files. Should fix or may consider placing a check to ensure input bib files and R outputs are kept separate.

cristinasparks commented 5 years ago

If you remove line 117 crminer::crm_cache$delete_all() the .bib file stays in the folder, however it also leaves a weird unopenable .pdf in the folder. Working on figuring this out