ScienceCommons / api

API for interacting with Curate Science model
http://curatescience.org
MIT License
2 stars 4 forks source link

show replications button not working if replications sandwiched between original studies #218

Closed eplebel closed 9 years ago

eplebel commented 9 years ago

e.g. https://www.curatescience.org/beta/#/articles/59309

if you click on the "3" Show/Hide replication button to hide the replications, then click on it again to show replications, it briefly shows them , but hides them again. however, if you click anywhere on the page, the replications do expand. (UPDATE: actually, i just noticed once replication studies are hidden, clicking anywhere on the page expands/shows them, wtf.)

if you remove the last original study (i.e., Correll, 2008, Study 3) -- and therefore replications not sandwiched between original studies, then everything works fine!

UPDATE: problem seems to occur only for specific articles: https://www.curatescience.org/beta/#/articles/59309 https://www.curatescience.org/beta/#/articles/49900

Somehow, problem does not seem to be happening for most other articles, e.g.: https://www.curatescience.org/beta/#/articles/107910 https://www.curatescience.org/beta/#/articles/335241 https://www.curatescience.org/beta/#/articles/335238 https://www.curatescience.org/beta/#/articles/53406 However, if you add a new original study to any of these articles, then the problem surfaces. (Problem also occurs for newly created original and replication studies;)

What a weird bug. Probably related to @manzhikov 's last changes (https://github.com/manzhikov/www/commit/fd4062635ed1fffb103f3cfe9462f1f6fcfaec94) and may be related to #216

eplebel commented 9 years ago

This now appears to be fixed, probably related to fixes for #216