search

ScienceCommons / curate_science

Transparency & credibility curation products for all research stakeholders.
https://CurateScience.org
MIT License
13 stars 6 forks source link

Search results/embed viewer fix: centering issue #148

Closed dolenda closed 4 years ago

dolenda commented 4 years ago

Fix from the full-screen mode enhancements #95

"search results page improvements: center article list div in left-panel, which will fix centering issue (same issue is currently affecting article page, see #64 ) and will fix the issue whereby the filter/sort buttons are being clipped on the right (see screenshot)"

I removed the column width constant and centered the article list div.

eplebel commented 4 years ago

looks OK when zoomed out at 80%, but in default 100% zoom (for 1920 × 950 viewport), the article card width is too wide and the transprency filter popup is also being clipped.

this is working correctly for the Recent and Author pages, so look there for clues on a fix.

image

Recent (where it's working) image

dolenda commented 4 years ago

interesting, at my 100% it looks good (for 1920 × 979 viewport), but still the left side of filter popup is aligned with the viewport border

Screenshot from 2020-09-01 12-07-30

dolenda commented 4 years ago

i moved the popup a bit to the right, so looks like this below now, but i'm not sure what to do with those differences between mine and your testing. i added Recent page for comparison

Screenshot_2020-09-01 Transparent credible evidence

Screenshot_2020-09-01 Transparent credible evidence (1)

eplebel commented 4 years ago

probably you have a larger viewport/screen resolution (because ya problem doesn't happen on my large monitor, only on my smaller laptop viewport)

dolenda commented 4 years ago

yes, you were right. i checked it for 1500 x 900 viewport (1499 is the threshold to show embedded content button) and the article list was too large. fixed it. now need to find a way to place filter popup in the left panel, because it still goes beyond the viewport (see the first picture). it appears that the same issue arises in the Recent page as well: the filter popup for small 1500 x 1900 viewport is too large (the second picture)

Screenshot from 2020-09-01 14-44-36

Screenshot from 2020-09-01 14-44-38

eplebel commented 4 years ago

you were right. i checked it for 1500 x 900 viewport (1499 is the threshold to show embedded content button) and the article list was too large. fixed it.

ok i hope your solution matches how it's working on the Recent and author pages

now need to find a way to place filter popup in the left panel, because it still goes beyond the viewport (see the first picture). it appears that the same issue arises in the Recent page as well: the filter popup for small 1500 x 1900 viewport is too large

but that's a different problem (popup is being displayed underneath the embed viewer), and i remember Mick saying that this is a difficult problem. so for now, just look to to the Recent and Author pages to see how the popup is specified differently to avoid being cut-off on the left (probably those positioning parameters)