ScienceCommons / curate_science

Transparency & credibility curation products for all research stakeholders.
https://CurateScience.org
MIT License
13 stars 6 forks source link

outstanding issues for initial beta release #46

Closed eplebel closed 5 years ago

eplebel commented 5 years ago

Article List/Author Page

Article EDITOR

Other:

alexkyllo commented 5 years ago

raise error if admin tries to invite a user with pre-activated author page that is already linked to another user account (see github comment)

Just pushed this to staging.

Example API error is:

400 Bad Request

{
    "email": [
        "This field must be unique."
    ]
}
eplebel commented 5 years ago

great, thanks Alex!

onejgordon commented 5 years ago

update website-wide icon (new snail logo as on alpha page; link to icon )

Site-wide meaning the favicon? I replaced the top bar snail icon with a new vector version that I created based on the sample given which was a PNG and not ideal for multi-scale use. We can use this (either black or white, up to you) for the favicon as well.

fix impact metrics “as of Date” (it should be date of last edit for specific impact metric field; currently, it seems to be the date of last article edit (OR seems to be the correct date if 2 impact metric fields are updated)

As far as I'm aware articles store a single update date, and do not have a property for each impact metric. @alexkyllo can confirm.

add missing article type label borders for “reanalysis – reprod/robustness”, “reanalysis – meta-analysis”, and “reanalysis – meta-research” article types

Is this about the color of the article type label border?

Screen Shot 2019-04-06 at 11 47 02 AM
onejgordon commented 5 years ago

within "ADD A FIGURE..." component, remove “ADD FIGURE” and “Cancel” buttons given that images automatically upload upon selection

Can we leave the 'cancel' button since otherwise there's no way to close the 'add a figure' panel that appears if user decides against it.

eplebel commented 5 years ago

Can we leave the 'cancel' button since otherwise there's no way to close the 'add a figure' panel that appears if user decides against it.

sure

Is this about the color of the article type label border?

yup looks fine

Site-wide meaning the favicon?

yup that's what i meant, and please just use the existing one from the alpha site: http://curatescience.org/logos/author-logos/CS-snail-icon.png <link rel="icon" type="image/png" href="../logos/author-logos/CS-snail-icon.png">

As far as I'm aware articles store a single update date, and do not have a property for each impact metric.

ah ok, but i guess there's still a bug where if you edit a impact metric value, it doesn't display the correct update date. but if you change the same impact metric a 2nd time or a different impact metric value, it does display the correct update date (for example, i just updated # of downloads for "Heightened sensitivity.." article on https://curatescience-staging.appspot.com/app/author/etienne-lebel and it still says "as of 3/31/2019"; but if i edit it a 2nd time, it will show the correct update date).

for the preregistration type text for Registered Report, please use the text "Peer-reviewed preregistered study design + analyses"

onejgordon commented 5 years ago

On update date, I'll look into why the UI isn't updating on each change, but to confirm: it's OK for now that any change to the article data model (e.g. title, authors, type, etc) will update the updated property, which is what shows when you hover over the impact measures.

eplebel commented 5 years ago

ya that's fine for now

onejgordon commented 5 years ago

add missing link icon (so users can share/link to a specific article card; as on alpha page, e.g.)

@eplebel where do you want the link icon now that the article type badge has moved down?

onejgordon commented 5 years ago

impact icons stylistic tweaks (view icon: "font-size: 14px; margin-bottom: -2px"; download: "font-size: 13px; margin-bottom: -1px"; citation: "font-size: 19px; margin-bottom: -5px")

I think what you're aiming to do here is vertically align the icons, and match up their size (since different icons take up slightly different amounts of the full character rectangle). I've adjusted the verticalAlign property of the icons to help do this in a slightly more robust way. I can still make the size tweaks if needed.

eplebel commented 5 years ago

I think what you're aiming to do here is vertically align the icons, and match up their size (since different icons take up slightly different amounts of the full character rectangle). I've adjusted the verticalAlign property of the icons to help do this in a slightly more robust way. I can still make the size tweaks if needed.

yes after tweaking their size, the icons weren't vertically aligning correctly with the verticalAlign property, so i had to resort to the margin-bottom hack (but perhaps something else was off).

eplebel commented 5 years ago

where do you want the link icon now that the article type badge has moved down?

good question. there's no obvious great spot for this now. ok let's just make it appear outside of the card (top-left) on card hover as follows (eventually we'll also have social media sharing functionalities): article-card-share-links

onejgordon commented 5 years ago

Linking should now be working on staging

eplebel commented 5 years ago

great, thanks so much! i've tested it so please push to master branch, thanks.