ScienceCommons / curate_science

Transparency & credibility curation products for all research stakeholders.
https://CurateScience.org
MIT License
13 stars 6 forks source link

full-screen mode details #63

Closed eplebel closed 4 years ago

eplebel commented 5 years ago

details of full-screen mode with side panel for viewing (supported) embeddable content: i.e., embeddable full-text PDFs, HTML articles/pages, interactive notebooks/code capsules, open peer review, supplementary materials PDF files, etc. (Live demo) HOMEPAGE-sep-2019_improved-sidePanel

for viewports > 1900px, a full-screen icon will appear immediately to the right of a supported embeddable content's external-link icon, which when clicked, will open (w/ animation if easy to add) a side-panel (to the right) and display the content within it (pressing the "ESC key" or "X" within the panel closes the panel). --> if viewport <1900px, full-screen icons are not visible, so user cannot enter full-screen mode (ensuring that the right-hand article card action buttons (i.e., "EDIT", "LINK", etc.) overflow over the vertical-scrollbar of the left-hand article list panel...)

full-screen mode will be available on the homepage (recent articles component), search results page, article page, and author page (but NOT for author page external embed widget for now).

(difficult) for contract#2, only the following embeddable content will be supported:

(NOTE: in the future, we should "validate" each full-screenable links, and only display a full-screen icon if link doesn't return a 404)





Content that will NOT (yet) be supported:

****various reasons why content cannot be embedded:

eplebel commented 4 years ago

your first pass at this @mickaobrien (https://github.com/ScienceCommons/curate_science/compare/ead2fd8357...74114fd5f3) is looking pretty good, I quite like it overall!

a few minor tweaks:

and plug in the fancyBox media viewer for all article key figures.

hopefully you can push these minor tweaks by friday, thanks so much!!

Untitled

eplebel commented 4 years ago

and plug in the fancyBox media viewer for all article key figures.

any chance for this?

mickaobrien commented 4 years ago

:crossed_fingers: Haven't had a chance to look at it yet, but I will. Hopefully it'll be a quick fix and I'll get it done today or tomorrow. I'll let you know either way.

eplebel commented 4 years ago

thx so much!

mickaobrien commented 4 years ago

Just push it in the latest comit (b12397181848e8f7fda546a24a86d7c505effc72). I think everything is working but have a look around and let me know if there are any issues.

eplebel commented 4 years ago

that's so awesome!!, thanks for squeezing this in. looks really delicious, i'm really happy with it (only noticed a tiny issue , but it can wait).

ok so you could you please "hot fix" these into production, i.e., fancyBox commit (https://github.com/ScienceCommons/curate_science/commit/b12397181848e8f7fda546a24a86d7c505effc72), and the max-width commit (https://github.com/ScienceCommons/curate_science/commit/639ff70d938d57d76c8c597812cef9413c922bad), and 3 other minor ones i pushed, typo (https://github.com/ScienceCommons/curate_science/commit/ead2fd8357ce4f2b78250922bad0998861d581f7), and 2 adding Mathijs as technical advisor (https://github.com/ScienceCommons/curate_science/commit/42d3d6c00a6e6f04d8e4e0ef73224f3d4278bfcb , https://github.com/ScienceCommons/curate_science/commit/dc0273fa52c74ba136f5b79c1ef18b3aeb73137f). thanks a million!

mickaobrien commented 4 years ago

:+1: Just pushed it there, looks good to me. Let me know if there are any issues.

eplebel commented 4 years ago

awesome!! everything looks good. only minor issue is that the max-width update isn't showing up correctly (see below). is it perhaps just a dist, bundle.js webpack issue?

Untitled

eplebel commented 4 years ago

actually, i don't think it's a simple bundle.js issue; i think the issue is due to the remaining min-width=650px in the ArticleList.jsx (see line29 ) , which you removed for the full-screen mode stuff. so ya, if you don't have time to fix this, no worries. and thanks again for squeezing in the FancyBox update!

mickaobrien commented 4 years ago

You're welcome!

Ah yeah, I see the issue. I might leave it for the moment if that's ok with you? The structure of these pages is a bit all over the place — the layouts and widths are being changed at several different levels of the component tree which can make it hard to figure out what's happening. We could probably do with cleaning up the overall structure at some stage so it's easier to control. Or just wait to merge in the full-screen stuff and it'll all be fine :laughing:

eplebel commented 4 years ago

ya sounds good... (and ya i think it's mostly already fixed within the full-screen changes). have a happy and relaxing holidays!

mickaobrien commented 4 years ago

Thanks, you too!

eplebel commented 4 years ago

here are the remaining minor issues to get achieve a scaled-back version of the full-screen mode specs:

please let me know if you have any questions @mickaobrien , thanks!

after full-screen mode is done, i'll do one last round of final testing and make a final small set of minor requests.