ScienceCore / climaterisk

Determining Climate Risks with NASA Earthdata Cloud
https://sciencecore.github.io/climaterisk/
Creative Commons Attribution Share Alike 4.0 International
2 stars 6 forks source link

Chapter 2 #28

Closed kvenkman closed 7 months ago

kvenkman commented 7 months ago

The PR primarily contains a python file created using jupytext from a notebook. It would be good for someone to take a look, see if it converts back into a notebook nicely, and is executable all the way through.

The PR also contains an updated environment.yml file to include a few new dependencies.

dhavide commented 7 months ago

@kvenkman , I have set up the environment with jupytext on my own MacBook machine. Some notes to consider:

kvenkman commented 7 months ago

Hi @dhavide ! You raise great points. I'll see what the issue is with the environment.yml. I'm also running into some reproducibility issues at my end with rasterio being unable to read datasets stored in the cloud, which I suspect to be a version issue with one of the underlying packages. I'll investigate and fix this.

Agreed on your third and fourth points - I'll modify the .gitignore and raise a PR. Let's discuss the write up of a Contributing.md document.