ScientaNL / DoctrineJsonFunctions

Doctrine DQL functions for SQL JSON data type
MIT License
547 stars 50 forks source link

feat: add support for dbal v4 #97

Closed simPod closed 9 months ago

simPod commented 10 months ago

I think this will require too much work to get is working on unsupported php versions. I'm willing to implement this is we drop <8.2 php support.

Hikariii commented 10 months ago

Great suggestion! This needs a major version upgrade, removing older unsupported php versions. Creating a 5.x branch and requiring php: ^8.1 support looks to me like the way forward.

Hikariii commented 10 months ago

I think this will require too much work to get is working on unsupported php versions. I'm willing to implement this is we drop <8.2 php support.

Dropping php 8.1 is too much for me, since php 8.1 is still supported by Doctrine 3 and dbal 4

simPod commented 10 months ago

Ok let me see what can be done.

simPod commented 10 months ago

Tests were the worst. CI is green, WDYT?

abozhinov commented 9 months ago

When to expect the new release?

Hikariii commented 9 months ago

When to expect the new release?

Release 5.5.0 supports orm 3

Hikariii commented 9 months ago

Tests were the worst. CI is green, WDYT?

Looks good, let me see if I can adopt and fix your work after a 5.x compatibility merge

Hikariii commented 9 months ago

Closed because this is merged via https://github.com/ScientaNL/DoctrineJsonFunctions/pull/109

simPod commented 9 months ago

I'm not as a contributor in release notes at dbal 4 support 🤔 🙃 🫠

Hikariii commented 8 months ago

I'm quite sure you are: https://github.com/ScientaNL/DoctrineJsonFunctions/pull/109/commits/b153ee24af6d1e9b75bb2654e7eeb1ea72969162 It is a shared commit.

simPod commented 8 months ago

Release notes

image