ScientiaFelis / sebmsR

Swedish Butterflies - tools and apps
GNU Affero General Public License v3.0
2 stars 0 forks source link

abundance_per_year_compare() have 1 week offset #27

Closed ScientiaFelis closed 8 months ago

ScientiaFelis commented 8 months ago

There seem to be a week offset in the data or presentation of weeks in figure. See issue #23 for figures

ScientiaFelis commented 8 months ago

This could be because excel and R count weeknr and start of week differently.

ScientiaFelis commented 8 months ago

isoweek() starts the week on Monday and follow ISO8601 standard.

week just count the first seven days from 1 of januari as the first week and so on.

@larspett should we change the week setting from isoweek()?

larspett commented 8 months ago

what do we currently use? isoweek? What does that give for April 1 2022 and September 30 2022? 13 & 39? Same for same dates in 2011?

ScientiaFelis commented 8 months ago

We use isoweek

2022-04-01 = W 13 2022-09-30 = W 39

2011-04-01 = W 13 2011-09-30 = W 39

larspett commented 8 months ago

Let’s keep that then

1 nov. 2023 kl. 19:30 skrev Georg @.***>:



We use isoweek

2022-04-01 = W 13 2022-09-30 = W 39

2011-04-01 = W 13 2011-09-30 = W 39

— Reply to this email directly, view it on GitHubhttps://github.com/ScientiaFelis/sebmsR/issues/27#issuecomment-1789451129, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEVQXZGGRIP3MILZWATFAA3YCKIKVAVCNFSM6AAAAAA6YANKBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGQ2TCMJSHE. You are receiving this because you were assigned.Message ID: @.***>

larspett commented 8 months ago

looks fine