Make fixed groups of max values - Githubissues

ScientiaFelis / sebmsR

Swedish Butterflies - tools and apps

GNU Affero General Public License v3.0

2 stars 0 forks source link

Make fixed groups of max values #28

Closed ScientiaFelis closed 8 months ago

ScientiaFelis commented 8 months ago

Create a new function that contain groups of set max limits and set the limit based on the max value of the data.

[x] create values of max limits
[x] set maxlimit to a figure based on if max value is within that linimt below a value based on limit size

larspett commented 8 months ago

steps_for_2022_lock_instead_of _dynamic.xlsx

larspett commented 8 months ago

It looks good! Some tweaks and additions;

3000 500 2900 (new step)
300 50 275 (new)
30 5 28 (new)
800 100 750 (new)
12000 2000 11000 (new)
14000 2000 13000 (new)
4000 500 3750 (new)
5000 1000 4500 (new)
6000 1000 5500 (new)
7000 1000 6500 (new)
8000 1000 7500 (new)
10000 2000 9000 (new)

larspett commented 8 months ago

and: 16000 2000 15000 18000 2000 17000 20000 5000 19000

larspett commented 8 months ago

PS använd samma skalor för sebms_abundance_year_compare_plot()

ScientiaFelis commented 8 months ago

pushat till github Testa gärna @larspett

larspett commented 8 months ago

0 to 3000 should have step 500
10000 becomes 1e+04 but should be 10000
year ranges get the first year but not the range (i.e. 2018:2022 becomes 2018, Brun blåvinge_2018-2022.png etc would be better

Otherwise looks fine but somehow two folders have been created to at the same time, wonder where they came from but not anything I have consciously coded

larspett commented 8 months ago

I suggest we fix this one first @ScientiaFelis

ScientiaFelis commented 8 months ago

Ok, I need to:

[x] set option to not give scientific numbers
[x] check steps (specifically 0-3000 --> 500 steps)
[x] rename species agg. If they are the only one (saving a name as Rapsfjäril/Rovfjäril creates a directory Rapsfjäril with Rovsjäril.png in)

larspett commented 8 months ago

Ahhh so that’s the reason for the directory!

From: Georg @.> Sent: den 2 november 2023 15:06 To: ScientiaFelis/sebmsR @.> Cc: Lars Pettersson @.>; Mention @.> Subject: Re: [ScientiaFelis/sebmsR] Make fixed groups of max values (Issue #28)

Ok, I need to:

[ ] set option to not give scientific numbers
[ ] check steps (specifically 0-3000 --> 500 steps)
[ ] rename species agg. If they are the only one (saving a name as Rapsfjäril/Rovfjäril creates a directory Rapsfjäril with Rovsjäril.png in)

— Reply to this email directly, view it on GitHubhttps://github.com/ScientiaFelis/sebmsR/issues/28#issuecomment-1790803736, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEVQXZFATZTRESWG6WAURITYCOSGJAVCNFSM6AAAAAA6ZBX55CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQHAYDGNZTGY. You are receiving this because you were mentioned.Message ID: @.**@.>>

ScientiaFelis commented 8 months ago

@larspett can you test Should work now