Closed sykhro closed 5 years ago
Since we are already using gtest, which advantages have fmtlib over glog?
fmtlib
is a generic formatting library which is useful for all sorts of things other than logging (much faster than stringstreams, allows for python-like string manipulation); what replaces glog here is the new Logger
class, which should be lighter and functionally equivalent (also easier to integrate with a future gui)
This pull request introduces 1 alert when merging 810375a05f58845597485ac50326f1b82648a441 into cd4b913dd0b29c0e8cd4a25567305113ab0191cb - view on LGTM.com
new alerts:
Comment posted by LGTM.com
Preliminary logging system implementation, posting here for comments/suggestions. I went for
fmtlib
directly instead ofspdlog
because we needed a wrapper anyway and also because it can be used to replace usage ofstd::stringstream
s, which are far less pretty.TODO:
side note:
fmtlib
was not added via git-subtree in order to avoid useless bloat