search

Scifabric / pbs

PYBOSSA command line client
GNU Affero General Public License v3.0
10 stars 11 forks source link

Additional error checking on API calls; See #12 #47

Closed cosmocracy closed 6 years ago

cosmocracy commented 7 years ago

Ensure the payload contains a status attribute since existing code doesn't properly handle failure (i.e., assumes success if it doesn't see the failure it expects)

cosmocracy commented 7 years ago

Looks like the tests are failing because the mocked responses aren't including a the status attribute returned by the API. Perhaps my PR should also fix this issue?

cosmocracy commented 7 years ago

Canceling this PR as the API tests don't consistently include mocked status and status_code values.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 98.921% when pulling 719fe573b6836ceb0422c99b46ec11f161a30655 on cosmocracy:master into 2d241f6dd721b5cf2be24e7288aa3d32fb3317d5 on Scifabric:master.

cosmocracy commented 7 years ago

FYI, @teleyinex. This might resolve #12 / #47

teleyinex commented 7 years ago

This looks good! Please sign the CONTRIBUTION agreement and we will merge it!

teleyinex commented 6 years ago

Apologies for the really long delay!