issues
search
ScilifelabDataCentre
/
dds_web
A cloud-based system for the delivery of data from SciLifeLab Facilities to their users (e.g. research group).
Other
7
stars
7
forks
source link
Fixed typo in technical overview
#1453
Closed
i-oden
closed
1 year ago
i-oden
commented
1 year ago
Before submitting this PR
Description:
Joanna found an error in the technical overview regarding the statuses. This fixes it.
Jira task / GitHub issue:
DDS-1624
How to test:
Add information on how someone could manually test this functionality. As detailed as possible.
Type of change:
Check the relevant boxes in the section below
Add docstrings and comments to code
,
even if
you personally think it's obvious.
What
type of change(s)
does the PR contain?
[ ] New feature
[ ] Breaking:
Please describe the reason for the break and how we can fix it.
[ ] Non-breaking
[ ] Database change
[ ] Migration
included in PR
[ ] Migration
not needed
[ ] Bug fix
[ ] Breaking:
Please describe the reason for the break and how we can fix it.
[ ] Non-breaking
[ ] Security Alert fix
[x] Documentation
[ ] Tests
(only)
[ ] Workflow
Checklist
Sprintlog
[ ] Added
[x] Not needed (E.g. PR contains
only
tests)
Rebase / Update / Merge
from
base branch (the branch from which the current is forked)
[x] Done
[ ] Not needed
Blocking PRs
[ ] Merged
[x] No blocking PRs
PR to
master
branch
[ ] Yes: Read
the release instructions
[ ] I have followed steps 1-8.
[x] No
Actions / Scans
Black
: Python code formatter. Does not execute. Only tests. Run
black .
locally to execute formatting.
[x] Passed
Prettier
: General code formatter. Our use case: MD and yaml mainly. Run
npx prettier --write .
locally to execute formatting.
[x] Passed
Yamllint
: Linting of yaml files.
[x] Passed
Tests
: Pytest to verify that functionality works as expected.
[ ] New tests added
[x] No new tests
[x] Passed
CodeQL
: Scan for security vulnerabilities, bugs, errors
[ ] New alerts:
Go through them and either fix, dismiss och ignore. Add reasoning in items below.
[ ] Alerts fixed:
What?
[ ] Alerts ignored / dismissed:
Why?
[x] Passed
Trivy
: Security scanner
[ ] New alerts:
Go through them and either fix, dismiss och ignore. Add reasoning in items below.
[ ] Alerts fixed:
What?
[ ] Alerts ignored / dismissed:
Why?
[x] Passed
Snyk
: Security scanner
[ ] New alerts:
Go through them and either fix, dismiss och ignore. Add reasoning in items below.
[ ] Alerts fixed:
What?
[ ] Alerts ignored / dismissed:
Why?
[x] Passed
Before submitting this PR
What type of change(s) does the PR contain?
Checklist
master
branchActions / Scans
black .
locally to execute formatting.npx prettier --write .
locally to execute formatting.