ScilifelabDataCentre / dds_web

A cloud-based system for the delivery of data from SciLifeLab Facilities to their users (e.g. research group).
Other
8 stars 8 forks source link

Set sto2 vars as nullable #1462

Closed i-oden closed 1 year ago

i-oden commented 1 year ago

Before submitting this PR

  1. Description: When Erik was trying to add a new unit to the testing instance, he got an error message saying that sto2* arguments could not be null. It appears that we never set them to nullable in the database when we added the sto4 variables. This PR does that.
  2. Jira task / GitHub issue: DDS-1663
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

Checklist

Actions / Scans

codecov[bot] commented 1 year ago

Codecov Report

Merging #1462 (e029629) into dev (190e114) will increase coverage by 0.54%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1462      +/-   ##
==========================================
+ Coverage   89.51%   90.05%   +0.54%     
==========================================
  Files          29       29              
  Lines        4396     4396              
==========================================
+ Hits         3935     3959      +24     
+ Misses        461      437      -24     
Files Changed Coverage Δ
dds_web/database/models.py 96.18% <100.00%> (ø)

... and 1 file with indirect coverage changes