Expired link is deleted from database when expired

[rv0lt]

Before submitting this PR

1. Description: When an invite is sent, the expiry time is set to exactly 7 days from now (incl the time). At midnight there is a cronjob which finds the expired invites in the Invites table and removes them. This means that there is a gap between the actual expiry and when the invite is deleted from the database. This PR fixes that. As well as adding some tests

2. Jira task / GitHub issue: https://scilifelab.atlassian.net/jira/software/projects/DDS/boards/13?isInsightsOpen=true&selectedIssue=DDS-1642

3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.

4. Type of change: Check the relevant boxes in the section below

5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

• [x] New feature
  • [ ] Breaking: Please describe the reason for the break and how we can fix it.
  • [x] Non-breaking
• [ ] Database change
  • [ ] Migration included in PR
  • [ ] Migration not needed
• [x] Bug fix
  • [ ] Breaking: Please describe the reason for the break and how we can fix it.
  • [x] Non-breaking
• [ ] Security Alert fix
• [ ] Documentation
• [ ] Tests (only)
• [ ] Workflow

Checklist

• Sprintlog
  • [x] Added
  • [ ] Not needed (E.g. PR contains only tests)
• Rebase / Update / Merge from base branch (the branch from which the current is forked)
  • [x] Done
  • [ ] Not needed
• Blocking PRs
  • [ ] Merged
  • [x] No blocking PRs
• PR to master branch
  • [ ] Yes: Read the release instructions
  • [ ] I have followed steps 1-8.
  • [ ] No

Actions / Scans

• Black: Python code formatter. Does not execute. Only tests. Run black . locally to execute formatting.
  • [x] Passed
• Prettier: General code formatter. Our use case: MD and yaml mainly. Run npx prettier --write . locally to execute formatting.
  • [x] Passed
• Yamllint: Linting of yaml files.
  • [x] Passed
• Tests: Pytest to verify that functionality works as expected.
  • [x] New tests added
  • [ ] No new tests
  • [ ] Passed
• CodeQL: Scan for security vulnerabilities, bugs, errors
  • [ ] New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
  • [ ] Alerts fixed: What?
  • [ ] Alerts ignored / dismissed: Why?
  • [x] Passed
• Trivy: Security scanner
  • [ ] New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
  • [ ] Alerts fixed: What?
  • [ ] Alerts ignored / dismissed: Why?
  • [x] Passed
• Snyk: Security scanner
  • [ ] New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
  • [ ] Alerts fixed: What?
  • [ ] Alerts ignored / dismissed: Why?
  • [x] Passed

[codecov[bot]]

Codecov Report

Merging #1466 (753ead3) into dev (ca45daf) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1466      +/-   ##
==========================================
+ Coverage   90.11%   90.15%   +0.03%     
==========================================
  Files          29       29              
  Lines        4401     4407       +6     
==========================================
+ Hits         3966     3973       +7     
+ Misses        435      434       -1     

Files Changed	Coverage Δ
dds_web/api/schemas/user_schemas.py	88.88% <100.00%> (+0.65%)	:arrow_up:
dds_web/api/user.py	90.63% <100.00%> (+0.20%)	:arrow_up:

[rv0lt]

@i-oden You mean adding tests that check that the ProjectInviteKeys are removed right?

[i-oden]

@i-oden You mean adding tests that check that the ProjectInviteKeys are removed right?

@rv0lt Correct!

[rv0lt]

@i-oden like this changes I push you mean? I dont know How to check for example for the ddserr.databaseerror as that was already part of the code I just move it around.

[i-oden]

@i-oden like this changes I push you mean? I dont know How to check for example for the ddserr.databaseerror as that was already part of the code I just move it around.

What you've added now is a good start, but you'll need to change a bit and add a bit of code too. I can have a look tomorrow again and come with a suggestion!