ScilifelabDataCentre / dds_web

A cloud-based system for the delivery of data from SciLifeLab Facilities to their users (e.g. research group).
Other
7 stars 7 forks source link

Dds 1537 add title to the autogenerated email sent to users when they get access #1475

Closed rv0lt closed 11 months ago

rv0lt commented 11 months ago

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Modify the template for the emails researchers get when a project has been release to include also the project title

2. Jira task / GitHub issue

https://scilifelab.atlassian.net/jira/software/projects/DDS/boards/13?selectedIssue=DDS-1537

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

codecov[bot] commented 11 months ago

Codecov Report

Merging #1475 (ca812f3) into dev (e8688e3) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head ca812f3 differs from pull request most recent head 264fbe2. Consider uploading reports for the commit 264fbe2 to get more accurate results

@@           Coverage Diff           @@
##              dev    #1475   +/-   ##
=======================================
  Coverage   90.18%   90.19%           
=======================================
  Files          29       29           
  Lines        4424     4426    +2     
=======================================
+ Hits         3990     3992    +2     
  Misses        434      434           
Files Coverage Δ
dds_web/api/user.py 90.94% <100.00%> (+0.03%) :arrow_up: