ScilifelabDataCentre / dds_web

A cloud-based system for the delivery of data from SciLifeLab Facilities to their users (e.g. research group).
Other
7 stars 7 forks source link

Updated Semver package to address CVE #1490

Closed rv0lt closed 10 months ago

rv0lt commented 10 months ago

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Update Semver from 7.0.0 to 7.5.2 to address:


Semver is a package use for parsing semantic versioning. It is not use in any part of the application itself, but it is required by other libraries of Node (used to build the webpage).

The alert was triggered by the simple-update-notifier modue (here).

This node package is used to check for NPM updates. No part of the application makes use of it. It is a part of Node

The update therefore is not critical and should not affect any part of the code.

Lastly, as a final check. The changes from 7.0.0 to 7.5.2 of Semver are just bug fixes or new features, no backward incompatible changes

Changelog

2. Jira task / GitHub issue

https://scilifelab.atlassian.net/jira/software/projects/DDS/boards/13?selectedIssue=DDS-1831

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

codecov[bot] commented 10 months ago

Codecov Report

Merging #1490 (c1d485a) into dev (e48ce8a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1490   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          29       29           
  Lines        4617     4617           
=======================================
  Hits         4224     4224           
  Misses        393      393           
rv0lt commented 10 months ago

CONVERTING TO DRAFT IN ORDER TO EVALUATE ALL THE POSSIBLE NODE UPDATES IN A NEW TASK https://scilifelab.atlassian.net/jira/software/projects/DDS/boards/13?selectedIssue=DDS-1837