Closed rv0lt closed 9 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
a31996e
) 91.50% compared to head (e3da447
) 91.48%.
Files | Patch % | Lines |
---|---|---|
dds_web/api/user.py | 71.42% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have updated all the description of the "bad" methods to the proposed one
Nice! You wrote
The documentation is accessible in the same URL that hosts the dds, in the /documentation uri.
Not sure I'm understanding where to look?
Nice! You wrote
The documentation is accessible in the same URL that hosts the dds, in the /documentation uri.
Not sure I'm understanding where to look?
In a further PR, we changed it again. To have them under similar syntax within the two version of the endpoints:
https://testing.delivery.scilifelab.se/api/documentation/v3/
Nice! You wrote
The documentation is accessible in the same URL that hosts the dds, in the /documentation uri.
Not sure I'm understanding where to look?
In a further PR, we changed it again. To have them under similar syntax within the two version of the endpoints:
https://testing.delivery.scilifelab.se/api/documentation/v3/
Thanks! It looks great!
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Added Swagger documentation generation, and documented endpoints for authentication and files operations.
The documentation is accessible in the same URL that hosts the dds, in the /documentation uri.
During this, some endpoints were discovered to be not up-to-date with the open API standard. Get and Delete methods cannot have data in the request body.
For now, they are marked as deprecated, it will be worked in the future to implement new versions of them correctly used. And be eventually replaced.
--
In this PR the "/user/second_factor" is fixed by providing an implementation that uses POST to submit the request of the token - The method already provides is a GET
No tests are implemented, as it could be reused the existing ones. Replacing the endpoint in them as the old one is eventually removed.
--
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
master
branch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.