Closed valyo closed 7 months ago
Just to understand. With development environment we mean the local setup, right?
yes, local development setup
Could the pytest error be related for no setting the user directive in the testing docker compose files ?
I didn't dig deeper yet, but this could be worth trying
It is not so simple, unfortunately, there are issues with both DB sqlite file and writing in the coverage file. I'll leave this for the moment, the path fix is more important.
@rv0lt this issue seems to come from some codecov settings on Github for our repo. At least this is my best guess, because the issue does not appear in the local dev setup. Unfortunately I don't have access to the repo settings to check if there are codecov related stuff. You can take a look in case there's something I am totally missing.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1e84447
) 91.48% compared to head (e8e6c45
) 91.48%.:exclamation: Current head e8e6c45 differs from pull request most recent head 0e63a8b. Consider uploading reports for the commit 0e63a8b to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Since we are running all containers in production and testing as non-root, we should do the same in our development environment to avoid issues like DDS-1845
2. Jira task / GitHub issue
DDS-1846
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
master
branch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.