ScilifelabDataCentre / dds_web

A cloud-based system for the delivery of data from SciLifeLab Facilities to their users (e.g. research group).
Other
7 stars 7 forks source link

run backend container as a non-root user #1498

Closed valyo closed 7 months ago

valyo commented 9 months ago

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Since we are running all containers in production and testing as non-root, we should do the same in our development environment to avoid issues like DDS-1845

2. Jira task / GitHub issue

DDS-1846

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

rv0lt commented 9 months ago

Just to understand. With development environment we mean the local setup, right?

valyo commented 9 months ago

yes, local development setup

rv0lt commented 9 months ago

Could the pytest error be related for no setting the user directive in the testing docker compose files ?

valyo commented 9 months ago

I didn't dig deeper yet, but this could be worth trying

valyo commented 9 months ago

It is not so simple, unfortunately, there are issues with both DB sqlite file and writing in the coverage file. I'll leave this for the moment, the path fix is more important.

valyo commented 7 months ago

@rv0lt this issue seems to come from some codecov settings on Github for our repo. At least this is my best guess, because the issue does not appear in the local dev setup. Unfortunately I don't have access to the repo settings to check if there are codecov related stuff. You can take a look in case there's something I am totally missing.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1e84447) 91.48% compared to head (e8e6c45) 91.48%.

:exclamation: Current head e8e6c45 differs from pull request most recent head 0e63a8b. Consider uploading reports for the commit 0e63a8b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1498 +/- ## ======================================= Coverage 91.48% 91.48% ======================================= Files 29 29 Lines 4637 4637 ======================================= Hits 4242 4242 Misses 395 395 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.