ScilifelabDataCentre / dds_web

A cloud-based system for the delivery of data from SciLifeLab Facilities to their users (e.g. research group).
Other
8 stars 8 forks source link

add "/tmp/" as csv file location #1499

Closed valyo closed 10 months ago

valyo commented 10 months ago

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

The new command flask send-usage fails on our production and testing instances with the following error:

OSError: [Errno 30] Read-only file system: 'snpseq_Usage_Months-11-to-11.csv

The reason is that in these environments we are running the containers as non-root (in contrast to our dev environment, separate task for this should be created and linked).

2. Jira task / GitHub issue

https://scilifelab.atlassian.net/browse/DDS-1845

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (034874a) 91.50% compared to head (3491e77) 91.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1499 +/- ## ======================================= Coverage 91.50% 91.50% ======================================= Files 29 29 Lines 4624 4625 +1 ======================================= + Hits 4231 4232 +1 Misses 393 393 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

i-oden commented 1 month ago

Question: Just double checking so that we're sure that the tmp folder in production is not emptied etc prior to us having the files?