Closed aishling-scilifelab closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.49%. Comparing base (
c4aeea5
) to head (90b2ee2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rv0lt I'm really on the fence about the second last commit (5feee92d373ee878f70c9bacf0cd7f4a5d40628d) so would love to know what you think. I embedded the PDF to try and re-create the functionality that was already there but it's not really clear to me that it's worth having anything other than a downloadable PDF.
@rv0lt in addition to getting rid of the embedded PDF, I also renamed the downloaded PDF to be dds-technical-overview.pdf on the basis that it's kind of useful to have it labelled as DDS when it's on the user's computer.
Read this before submitting the PR
If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.
1. Description / Summary
Add a summary of the changes in this PR and the related issue.
2. Jira task / GitHub issue
Link to the github issue or add the Jira task ID here.
3. Type of change
What type of change(s) does the PR contain?
Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.
4. Additional information
master
branch: _If checked, read the release instructions5. Actions / Scans
Check the boxes when the specified checks have passed.
For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.