search

ScilifelabDataCentre / dds_web

A cloud-based system for the delivery of data from SciLifeLab Facilities to their users (e.g. research group).
Other
8 stars 8 forks source link

Bump actions/checkout to v4 #1556

Closed valyo closed 2 weeks ago

valyo commented 1 month ago

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Bump checkout action to v4, after noticing warning: The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.53%. Comparing base (3414ef7) to head (f443da9). Report is 72 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1556 +/- ## ========================================== + Coverage 92.52% 92.53% +0.01% ========================================== Files 29 29 Lines 4868 4878 +10 ========================================== + Hits 4504 4514 +10 Misses 364 364 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rv0lt commented 1 month ago

Just wondering if we shouldn't update all instances of actions/checkout@v4 and not only this workflow file?

Also, I updated the branch and resolved the sprintlog, and now checks are failing again, not sure why?

Again the too many requests, if you run it locally with the vpn it also hits it. Yesterday it also happened a lot with the PRs. They must have decreased the limits recently or there is something that changed, because it is too much of a coincidence now

I read somewhere a solution to cache images to avoid pulling them in the Actions everytime, only solution for now is to re-run the jobs after a time

image

i-oden commented 1 month ago

Just wondering if we shouldn't update all instances of actions/checkout@v4 and not only this workflow file? Also, I updated the branch and resolved the sprintlog, and now checks are failing again, not sure why?

Again the too many requests, if you run it locally with the vpn it also hits it. Yesterday it also happened a lot with the PRs. They must have decreased the limits recently or there is something that changed, because it is too much of a coincidence now

I read somewhere a solution to cache images to avoid pulling them in the Actions everytime, only solution for now is to re-run the jobs after a time

image

🙃

i-oden commented 3 weeks ago

For some reason I cannot "Approve" or "Request changes" here, only "Comment". It looks good, maybe as Ina suggested we should bump this action in all our workflows.

@valyo You can't approve because you created the PR 😄 So you're the one making potential changes to the other actions as well

valyo commented 3 weeks ago

For some reason I cannot "Approve" or "Request changes" here, only "Comment". It looks good, maybe as Ina suggested we should bump this action in all our workflows.

@valyo You can't approve because you created the PR 😄 So you're the one making potential changes to the other actions as well

🙃 this explains a lot

valyo commented 3 weeks ago

ok, if we have agreed that all actions should be bumped, I'll add the changes in this PR

i-oden commented 3 weeks ago

ok, if we have agreed that all actions should be bumped, I'll add the changes in this PR

Yes go ahead and do that

i-oden commented 2 weeks ago

@valyo This was a mistake on my end. I was suppose to push to my PR. I'll fix this PR instead.