ScilifelabDataCentre / dds_web

A cloud-based system for the delivery of data from SciLifeLab Facilities to their users (e.g. research group).
Other
8 stars 8 forks source link

New release: v2.8.1 #1563

Closed i-oden closed 2 weeks ago

i-oden commented 3 weeks ago

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

New release of DDS

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.53%. Comparing base (93b485f) to head (f6aa2d1). Report is 77 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1563 +/- ## ========================================== + Coverage 92.49% 92.53% +0.04% ========================================== Files 29 29 Lines 4851 4878 +27 ========================================== + Hits 4487 4514 +27 Misses 364 364 ``` | [Flag](https://app.codecov.io/gh/ScilifelabDataCentre/dds_web/pull/1563/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScilifelabDataCentre) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/ScilifelabDataCentre/dds_web/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScilifelabDataCentre) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ScilifelabDataCentre#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rv0lt commented 2 weeks ago

@valyo Can you merge? It still says blocked for me

valyo commented 2 weeks ago

@rv0lt I don't even have the merge option, it says: This branch is out-of-date with the base branch Merge the latest changes from master into this branch. This merge commit will be associated with valentin.georgiev@scilifelab.uu.se. but the update fails