search

ScilifelabDataCentre / genome-portal

This is the repository for the Swedish Reference Genome Portal, a service facilitating access and discovery of genome data of non-model eukaryotic species studied in Sweden
https://genomes.scilifelab.se/
MIT License
0 stars 0 forks source link

Edits to FAQs and footer #68

Closed apfuentes closed 1 day ago

apfuentes commented 2 days ago

This PR includes text editions and collapsible box sections for the FAQs page, text update of the About section of the footer (following the recommended wording), a new link to the Terms of use page, and the User guide.

Help to modify a few details in the footer are needed, which are described here https://github.com/ScilifelabDataCentre/genome-portal/pull/67#issuecomment-2458386608.

RMCrean commented 2 days ago

Help to modify a few details in the footer are needed, which are described here https://github.com/ScilifelabDataCentre/genome-portal/pull/67#issuecomment-2458386608.

Thanks, I will work on the issues described about the hugo/layouts/partials/footer.html file here and commit a change to this branch then.

RMCrean commented 2 days ago

I'm finished with changes to the footer, I will work on the navbar on this branch now, I will therefore be editing the files: hugo/layouts/partials/navbar.html and hugo/assets/css/styles.css.

apfuentes commented 2 days ago

First part of the User guide in 334e3c9

apfuentes commented 2 days ago

Perfect! Thanks @brinkdp for the edits.

brinkdp commented 2 days ago

@apfuentes I've now looked at the current version of the user guide (everything until 2. Useful genome browser features). It looks excellent! This is quite some work, thank you so much for this! I have nothing to add for now.

@RMCrean After the latest Navbar update, User guide renders on two lines in Firefox on my computer. Zoom level and responsiveness does not seem to affect it. When I open it in Safari, the link conforms to the bottom line as I think is intended.

Firefox: Screenshot 2024-11-06 at 16 47 27

Safari: Screenshot 2024-11-06 at 16 52 55

apfuentes commented 2 days ago

Thank you @brinkdp for your kind words, and for reviewing the User guide!

Regarding the two-row nav bar, I wonder if it would possible to make the bottom text align a bit, as shown here: Screenshot 2024-11-06 at 18 09 49

Not sure how to fix the wrap-text issue in different browsers, nicely spotted @brinkdp.

RMCrean commented 1 day ago

Hi all, I will fix the conflict now.

Thanks for the report @brinkdp, I will work on this now and then I can merge it.

Thanks @apfuentes, it's hard to get them to line up exactly so I'll see what I can do now (but I will be working on the presentation instead most of today), otherwise I'll save this for after the launch.

RMCrean commented 1 day ago

@brinkdp, I've dropped the font sizes and image sizes for the different screen sizes where the navbar is expanded, as I couldn't reproduce your issue on my firefox or chrome, could you pull the latest changes and if it looks okay, merge this branch?

apfuentes commented 1 day ago

I just spotted a few typos in FAQ page, I will change them now.

apfuentes commented 1 day ago

@RMCrean any idea why Trivy - Security scan is failing? How can this be fixed?

brinkdp commented 1 day ago

The navbar looks good now, thanks @RMCrean! The Trivy thing has been going on for a few weeks now and it is nothing major to worry about. It seems that they get so many requests that the checks sometimes time-out and give a fail message.