search

Scille / parsec-cloud

Open source Dropbox-like file sharing with full client encryption !
https://parsec.cloud
Other
271 stars 40 forks source link

[🐛 | Bug]: Invalid app state after a logout error #8489

Closed mmmarcos closed 22 hours ago

mmmarcos commented 2 months ago

Parsec version tested on:

3.0.0

Platforms tested on:

Linux

Bug description:

This is a follow-up to issue #8488 : everything related to the organization remains in an invalid state if an error occurs during a logout:

  1. Click "Go to home"
  2. Organization displays "Logged in"
  3. Click on organization, opens the organization in an invalid state (no workspace, no items)
  4. Button "Go to home" is no longer displayed
  5. Need to close and restart app to return to a valid state.

Relevant output:

No response

mmmarcos commented 2 months ago

It should be rather easy to reproduce by simulating errors during logout.

mmmarcos commented 2 months ago

The logout function does not do anything strange: https://github.com/Scille/parsec-cloud/blob/b44568f5b272e731e4fb874cca632c1589af26fe/client/src/parsec/login.ts#L234-L241

However, calls to logout seem to "ignore" error cases (only displays message):
https://github.com/Scille/parsec-cloud/blob/b44568f5b272e731e4fb874cca632c1589af26fe/client/src/views/header/ProfileHeader.vue#L146-L151

https://github.com/Scille/parsec-cloud/blob/b44568f5b272e731e4fb874cca632c1589af26fe/client/src/main.ts#L330-L336

FirelightFlagboy commented 2 months ago

I have a step to reproduce a logout error using a local server: https://github.com/Scille/parsec-cloud/issues/8381#issuecomment-2371035866

NicoTuxx commented 3 days ago

What do we do with that?

NicoTuxx commented 22 hours ago

no more relevant according to @Max-7