search

ScintillatorSynth / Scintillator

A Video Synthesis Engine for SuperCollider
https://scintillatorsynth.org
56 stars 8 forks source link

ScinServerInstaller - fix indentation #123

Closed jrsurge closed 4 years ago

jrsurge commented 4 years ago

Purpose and motivation

PR #122 added a line incorrectly indented with spaces instead of tabs, this PR addresses that

There's also a line break in line 269 that doesn't necessarily need to be there?

Types of changes

Status

lnihlen commented 4 years ago

I don't have a strong opinion about line breaks in sclang code. The C++ code, however, is formatted to a 120-column rule. So I've been informally breaking lines on the sclang code whenever they start to feel "too long." I also prefer breaking in the middle of function arguments, oddly, because the automatic indentation in SCIDE doesn't seem to understand chaining of functions as worthy of indenting, so breaking on the dot, which would be much more readable IMHO, isn't also a good option.

This is along way of saying I'll defer to your judgement on matters of sclang style.

lnihlen commented 4 years ago

Sorry for sleeping on this!