ScintillatorSynth / Scintillator

A Video Synthesis Engine for SuperCollider
https://scintillatorsynth.org
56 stars 8 forks source link

Delay StatusPoller OSCFunc/SkipJack instantiation until server boot #173

Closed nhthn closed 4 years ago

nhthn commented 4 years ago

Purpose and motivation

Fix #172.

Implementation

ScinServerStatusPoller, on initialization, no longer automatically creates its OSCFunc/SkipJack. The creation of these monitoring objects is deferred until the start instance method is called on the ScinServerStatusPoller.

This fixes what appears to be a race condition when creating an OSCFunc during class tree initialization, and also prevents the ScinServerStatusPoller from being broken by a CmdPeriod call between instantiation of the server and booting of the server. It does not yet make the StatusPoller entirely impervious to CmdPeriod.

Types of changes

Status

lnihlen commented 4 years ago

Thanks for the PR!