search

ScionSpy / G-C-A_V2

MIT License
1 stars 0 forks source link

BUG - ClanBattles - Results #9

Closed ScionSpy closed 1 month ago

ScionSpy commented 1 month ago

Describe the bug

When the results post for "Struggle" results indicate all wins, and losses, are wins.

To Reproduce

Steps to reproduce the behavior:

  1. Enter the struggle.
  2. Win a battle.
  3. Lose a battle.
  4. Post results, all struggle with show as "Win" (Full Star)

Expected behavior

Struggle win as a complete star, and struggle losses as an empty star.

Screenshots

image image

ScionSpy commented 1 month ago

https://github.com/ScionSpy/G-C-A_V2/blob/b6b9e35a0eec995b9c1de4253284b975dced7338/Src/Modules/ClanBattles/Classes/Battle.js#L147

stage.progress[x] ? -> stage.progress[x] == 'victory' ?